Changed type evaluation logic for member access expressions for `type… #6553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…[Any]` where the target attribute is not explicitly declared in the `type` or `object` class. Previously, pyright emitted an error in this case. This addresses #6552.
|
Diff from mypy_primer, showing the effect of this PR on open source code: spack (https://github.com/spack/spack)
- /tmp/mypy_primer/projects/spack/lib/spack/spack/build_environment.py:1524:26 - error: Cannot access member "module" for type "type"
- Member "module" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/spack/lib/spack/spack/package_base.py:810:60 - error: Cannot access member "name" for type "type"
- Member "name" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/spack/lib/spack/spack/patch.py:140:59 - error: Cannot access member "module" for type "type"
- Member "module" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/spack/lib/spack/spack/patch.py:148:59 - error: Cannot access member "namespace" for type "type[Any]*"
- Member "namespace" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/spack/lib/spack/spack/patch.py:148:74 - error: Cannot access member "name" for type "type[Any]*"
- Member "name" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/spack/lib/spack/spack/repo.py:1130:48 - error: Cannot access member "name" for type "type[Any]"
- Member "name" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/spack/lib/spack/spack/repo.py:1128:45 - error: Cannot access member "name" for type "type[Any]"
- Member "name" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/spack/lib/spack/spack/repo.py:1226:74 - error: Cannot access member "virtual" for type "type[Any]"
- Member "virtual" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/spack/lib/spack/spack/test/build_environment.py:575:34 - error: Cannot access member "module" for type "type"
- Member "module" is unknown (reportGeneralTypeIssues)
- 3843 errors, 48 warnings, 0 informations
+ 3834 errors, 48 warnings, 0 informations
pydantic (https://github.com/samuelcolvin/pydantic)
- /tmp/mypy_primer/projects/pydantic/pydantic/_internal/_dataclasses.py:280:22 - error: Cannot access member "__dataclass_fields__" for type "type[Any]"
- Member "__dataclass_fields__" is unknown (reportGeneralTypeIssues)
- 53 errors, 0 warnings, 0 informations
+ 52 errors, 0 warnings, 0 informations
pandera (https://github.com/pandera-dev/pandera)
- /tmp/mypy_primer/projects/pandera/pandera/api/extensions.py:57:27 - error: Cannot access member "CHECK_FUNCTION_REGISTRY" for type "Type[Unknown]"
- Member "CHECK_FUNCTION_REGISTRY" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/pandera/pandera/backends/pyspark/decorators.py:47:34 - error: Cannot access member "typeName" for type "Type[Unknown]"
- Member "typeName" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/pandera/pandera/backends/pyspark/decorators.py:67:27 - error: Cannot access member "typeName" for type "Type[Unknown]"
- Member "typeName" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/pandera/pandera/engines/engine.py:193:21 - error: Cannot access member "_register_equivalents" for type "_EngineType[Unknown]"
- Member "_register_equivalents" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/pandera/pandera/engines/engine.py:196:21 - error: Cannot access member "_register_from_parametrized_dtype" for type "_EngineType[Unknown]"
- Member "_register_from_parametrized_dtype" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/pandera/pandera/engines/engine.py:198:17 - error: Cannot access member "_registered_dtypes" for type "_EngineType[Unknown]"
- Member "_registered_dtypes" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/pandera/pandera/engines/engine.py:209:38 - error: Cannot access member "_base_pandera_dtypes" for type "_EngineType[Unknown]"
- Member "_base_pandera_dtypes" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/pandera/pandera/engines/engine.py:215:43 - error: Cannot access member "_base_pandera_dtypes" for type "_EngineType[Unknown]"
- Member "_base_pandera_dtypes" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/pandera/pandera/engines/engine.py:228:24 - error: Cannot access member "_registry" for type "_EngineType[Unknown]"
- Member "_registry" is unknown (reportGeneralTypeIssues)
- 1207 errors, 10 warnings, 0 informations
+ 1198 errors, 10 warnings, 0 informations
discord.py (https://github.com/Rapptz/discord.py)
+ /tmp/mypy_primer/projects/discord.py/discord/utils.py:724:41 - warning: Unnecessary "# type: ignore" comment
+ /tmp/mypy_primer/projects/discord.py/discord/app_commands/transformers.py:783:39 - warning: Unnecessary "# type: ignore" comment
+ /tmp/mypy_primer/projects/discord.py/discord/app_commands/transformers.py:787:41 - warning: Unnecessary "# type: ignore" comment
+ /tmp/mypy_primer/projects/discord.py/discord/app_commands/transformers.py:795:35 - warning: Unnecessary "# type: ignore" comment
- 59 errors, 9 warnings, 0 informations
+ 59 errors, 13 warnings, 0 informations
dd-trace-py (https://github.com/DataDog/dd-trace-py)
- /tmp/mypy_primer/projects/dd-trace-py/tests/utils.py:1256:14 - error: Cannot assign member "pytestmark" for type "type[Any]"
- Member "pytestmark" is unknown (reportGeneralTypeIssues)
- Member "pytestmark" is unknown (reportGeneralTypeIssues)
- /tmp/mypy_primer/projects/dd-trace-py/tests/utils.py:1258:10 - error: Cannot access member "pytestmark" for type "type[Any]"
- 9457 errors, 464 warnings, 0 informations
+ 9455 errors, 464 warnings, 0 informations
hydra-zen (https://github.com/mit-ll-responsible-ai/hydra-zen)
+ /tmp/mypy_primer/projects/hydra-zen/tests/annotations/declarations.py:430:22 - error: Unnecessary "# type: ignore" comment
+ /tmp/mypy_primer/projects/hydra-zen/src/hydra_zen/structured_configs/_implementations.py:1117:48 - error: Unnecessary "# type: ignore" comment
+ /tmp/mypy_primer/projects/hydra-zen/src/hydra_zen/structured_configs/_implementations.py:1118:61 - error: Unnecessary "# type: ignore" comment
+ /tmp/mypy_primer/projects/hydra-zen/src/hydra_zen/structured_configs/_implementations.py:1119:43 - error: Unnecessary "# type: ignore" comment
- 149 errors, 0 warnings, 174 informations
+ 153 errors, 0 warnings, 174 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…[Any]
where the target attribute is not explicitly declared in thetypeorobject` class. Previously, pyright emitted an error in this case. This addresses #6552.