This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
__all__ evaluation #863
Merged
__all__ evaluation #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikhailArkhipov
approved these changes
Apr 2, 2019
jakebailey
added a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
Fixes microsoft#620. Fixes microsoft#619. This adds support for concatenating lists using `+`, doing `+=` on `__all__`, and calling `append` and `extend` on `__all__`. If something goes wrong (an unsupported operation on `__all__` or some unsupported value), then the old behavior continues to be used. I don't track uses of `__all__` indirectly (i.e. passing `__all__` to something that modifies it), only direct actions. If `__all__` is in a more complicated lvar (like `__all__, foo = ...`), then it is ignored. This can be improved later on when we fix up our multiple assignment issues. This works well for Django models (see microsoft#620), but `numpy`'s import cycles prevent this from having an effect, so the old behavior will be used. ~Tests are WIP.~ I'll need to rebase/merge master when the refs per gets merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #620.
Fixes #619.
This adds support for concatenating lists using
+, doing+=on__all__, and callingappendandextendon__all__. If something goes wrong (an unsupported operation on__all__or some unsupported value), then the old behavior continues to be used. I don't track uses of__all__indirectly (i.e. passing__all__to something that modifies it), only direct actions. If__all__is in a more complicated lvar (like__all__, foo = ...), then it is ignored. This can be improved later on when we fix up our multiple assignment issues.This works well for Django models (see #620), but
numpy's import cycles prevent this from having an effect, so the old behavior will be used.Tests are WIP.I'll need to rebase/merge master when the refs per gets merged.