Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pandas FutureWarning #1073

Merged
merged 3 commits into from Apr 27, 2022
Merged

Fixed pandas FutureWarning #1073

merged 3 commits into from Apr 27, 2022

Conversation

Hubedge
Copy link
Contributor

@Hubedge Hubedge commented Apr 24, 2022

Description

Fixing pandas FutureWarnings:
https://pandas.pydata.org/docs/whatsnew/v1.4.0.html#deprecated-dataframe-append-and-series-append
pandas-dev/pandas#42825

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

`FutureWarning: Passing a set as an indexer is deprecated and will raise in a future version. Use a list instead.`
```
scripts/data_collector/index.py:228: FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.
  new_df = new_df.append(_tmp_df, sort=False)
```
@ghost
Copy link

ghost commented Apr 24, 2022

CLA assistant check
All CLA requirements met.

@you-n-g
Copy link
Collaborator

you-n-g commented Apr 27, 2022

Thanks. It looks great!
Welcome to join Qlib's contributors

1 similar comment
@you-n-g
Copy link
Collaborator

you-n-g commented Apr 27, 2022

Thanks. It looks great!
Welcome to join Qlib's contributors

@you-n-g you-n-g merged commit 84ff662 into microsoft:main Apr 27, 2022
@you-n-g you-n-g added the bug Something isn't working label Jun 15, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* Fixed pandas FutureWarning

`FutureWarning: Passing a set as an indexer is deprecated and will raise in a future version. Use a list instead.`

* fixed another pandas FutureWarning

```
scripts/data_collector/index.py:228: FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.
  new_df = new_df.append(_tmp_df, sort=False)
```

* fixed more pandas futurewarnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants