fix_issue_1060 #1092
Merged
fix_issue_1060 #1092
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you-n-g
reviewed
May 7, 2022
| @@ -11,10 +12,11 @@ | |||
| import baostock as bs | |||
| from loguru import logger | |||
|
|
|||
| from scripts.data_collector.base import BaseCollector, BaseRun, BaseNormalize | |||
| from scripts.data_collector.utils import get_hs_stock_symbols, get_calendar_list | |||
| BASE_DIR = Path(__file__).resolve().parent | |||
There was a problem hiding this comment.
Are you sure this is not affected?
https://github.com/microsoft/qlib/blob/main/scripts/data_collector/pit/collector.py#L254
There was a problem hiding this comment.
Are you sure this is not affected? https://github.com/microsoft/qlib/blob/main/scripts/data_collector/pit/collector.py#L254
Yes, this doesn't affect the normal operation of the program.
|
|
||
| BASE_DIR = Path(__file__).resolve().parent.parent | ||
| from base import BaseCollector, BaseRun, BaseNormalize |
There was a problem hiding this comment.
base and utils may easily conflict with other modules.
Will data_collector will be better?
Closed
you-n-g
added
documentation
qianyun210603
pushed a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* fix_issue_1060 * fix_import_error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes