Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #1308

Merged
merged 1 commit into from Oct 7, 2022
Merged

Fix typo #1308

merged 1 commit into from Oct 7, 2022

Conversation

ChiahungTai
Copy link
Collaborator

Description

Fix typo.

Motivation and Context

#1300

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.
    Fix typo in comments.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@ChiahungTai
Copy link
Collaborator Author

@you-n-g
This is a typo patch.
You can review it very quick.

@ChiahungTai
Copy link
Collaborator Author

@you-n-g
The errors are not related to my commit. How do I fix it?
Uploading Screen Shot 2022-10-07 at 1.39.39 PM.png…

@you-n-g
Copy link
Collaborator

you-n-g commented Oct 7, 2022

Thanks for your contribution.
This CI error may be caused by an issue in windows.
I'll merge it first.

@you-n-g you-n-g merged commit b22ecd1 into microsoft:main Oct 7, 2022
@ChiahungTai ChiahungTai deleted the typo branch October 9, 2022 01:22
@you-n-g you-n-g added the documentation Improvements or additions to documentation label Dec 9, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@ChiahungTai
Fix typo (microsoft#1308)
50a1dda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChiahungTai @you-n-g