Fix typos and grammar errors in docstrings and comments #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChiahungTai
approved these changes
Nov 20, 2022
you-n-g
reviewed
Nov 20, 2022
| @@ -685,7 +685,7 @@ def cast(cls, handler: "DataHandlerLP") -> "DataHandlerLP": | |||
| the converted processed data | |||
| """ | |||
| new_hd: DataHandlerLP = object.__new__(DataHandlerLP) | |||
| new_hd.from_cast = True # add a mark for the casted instance | |||
| new_hd.from_cast = True # add a mark for the cast instance | |||
There was a problem hiding this comment.
The past tense of cast is: cast in past simple is cast. and past participle is cast. There is no casted.
There was a problem hiding this comment.
Sorry for my bad grammar...
|
It looks great now! |
qianyun210603
added a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* fix gramma error in doc strings * fix typos in exchange.py * fix typos and gramma errors * fix typo and rename function param to avoid shading python keyword * remove redundant parathesis; pass kwargs to parent class * fix pyblack * further correction * assign -> be assigned to
qianyun210603
added a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* fix gramma error in doc strings * fix typos in exchange.py * fix typos and gramma errors * fix typo and rename function param to avoid shading python keyword * remove redundant parathesis; pass kwargs to parent class * fix pyblack * further correction * assign -> be assigned to
qianyun210603
added a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* fix gramma error in doc strings * fix typos in exchange.py * fix typos and gramma errors * fix typo and rename function param to avoid shading python keyword * remove redundant parathesis; pass kwargs to parent class * fix pyblack * further correction * assign -> be assigned to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix some types and missing's in doc strings.
Motivation and Context
improve code quality
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes