Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpha.rst #143

Merged
merged 2 commits into from Dec 21, 2020
Merged

Update alpha.rst #143

merged 2 commits into from Dec 21, 2020

Conversation

bxdd
Copy link
Collaborator

@bxdd bxdd commented Dec 21, 2020

Description

Motivation and Context

Related #142

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation


[322025 rows x 1 columns]
>> data_handler = QlibDataLoader(config=data_loader_config)
>> df = data_handler.load(instruments='csi300', start_time='2010-01-01', end_time='2017-12-31')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use data_loader as the variable name instead of data_hander

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, other part of the page should be changed.
For example, add data loader in reference

@bxdd bxdd requested a review from you-n-g December 21, 2020 13:59
@you-n-g you-n-g merged commit 7e37fa7 into main Dec 21, 2020
@bxdd bxdd deleted the update_alpha_rst branch December 21, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants