Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xuyang1/refine task and implement workflow task as example #1528

Merged

Conversation

peteryang1
Copy link
Collaborator

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@github-actions github-actions bot added the waiting for triage Cannot auto-triage, wait for triage. label May 30, 2023
qlib/finco/task.py Outdated Show resolved Hide resolved
@@ -58,6 +168,29 @@ def exeute(self):
class ActionTask(Task):
def execute(self) -> Literal["fail", "success"]:
return "success"

"""Context Manager stores the context of the workflow"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring will be better


def update_context(self, latest_context):
"""assign the workflow context manager to the task"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring

@peteryang1 peteryang1 merged commit 421b140 into finco May 31, 2023
2 checks passed
@peteryang1 peteryang1 deleted the xuyang1/refine_task_and_implement_workflow_task_as_example branch May 31, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for triage Cannot auto-triage, wait for triage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants