Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update knowledge module; #1592

Merged
merged 5 commits into from Jul 16, 2023
Merged

Conversation

Fivele-Li
Copy link
Contributor

@Fivele-Li Fivele-Li commented Jul 12, 2023

  • add storage class;
  • new practice,execute,finance,infrastructure knowledge;
  • add query method to KnowledgeBase;

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

* add storage class;
* new practice,execute,finance,infrastructure knowledge;
* add query method to KnowledgeBase;
@github-actions github-actions bot added the waiting for triage Cannot auto-triage, wait for triage. label Jul 12, 2023
self.summarize()

def add(self, docs: List):
self.storage.add(docs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks more like a knowledge set.

Cadenza-Li and others added 4 commits July 13, 2023 17:20
* Knowledge.storage to storages list;
* optimize Knowledge & Storage save and load method;
* optimize Knowledge query prompt;
* Update CMDTask prompt example for Windows OS;
* Windows OS decode output of subprocess in gbk by default, specify encoding format explict;
* Add KnowledgeBase's 4 knowledge types to corresponding task;
@peteryang1 peteryang1 merged commit 5e0873c into microsoft:finco Jul 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for triage Cannot auto-triage, wait for triage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants