fix get data error #1793
Merged
fix get data error #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
you-n-g
reviewed
May 23, 2024
| @@ -27,7 +27,8 @@ pip install arctic # NOTE: pip may fail to resolve the right package dependency | |||
| 2. Please follow following steps to download example data | |||
| ```bash | |||
| cd examples/orderbook_data/ | |||
| python ../../scripts/get_data.py download_data --target_dir . --file_name highfreq_orderbook_example_data.zip | |||
| gdown https://drive.google.com/uc?id=15nZF7tFT_eKVZAcMFL1qPS4jGyJflH7e # Proxies may be necessary here. | |||
you-n-g
reviewed
May 23, 2024
| fernet = Fernet(self.KEY) | ||
| token = fernet.decrypt(self.TOKEN).decode() | ||
| return f"{self.REMOTE_URL}/{file_name}?{token}" | ||
| return f"{self.REMOTE_URL}/{file_name}" if "/" in file_name else f"{self.REMOTE_URL}/v0/{file_name}" |
There was a problem hiding this comment.
do you mean matching string like "v03" ?
SunsetWolf
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes