Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unrecognized config bug #183

Merged
merged 1 commit into from Jan 7, 2021
Merged

Fix unrecognized config bug #183

merged 1 commit into from Jan 7, 2021

Conversation

fzc621
Copy link
Contributor

@fzc621 fzc621 commented Jan 7, 2021

The config key should be checked first instead of assignment, otherwise the if-condition would never be true.

Description

Put the assignment statement after the if-statement.

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g
Copy link
Collaborator

you-n-g commented Jan 7, 2021

@fzc621 It's great!
Thanks so much!

@you-n-g you-n-g merged commit 231f373 into microsoft:main Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants