Update Highfreq Handler & Ops / Fix a Highfreq Bug #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you-n-g
reviewed
Feb 3, 2021
examples/highfreq/highfreq_ops.py
Outdated
| def __init__(self, feature, l=None, r=None): | ||
| self.l = l | ||
| self.r = r | ||
| if (self.l != None and self.l <= 0) or (self.r != None and self.r >= 0): |
There was a problem hiding this comment.
is None is better than != None
examples/highfreq/highfreq_ops.py
Outdated
|
|
||
| def get_extended_window_size(self): | ||
| ll = 0 if self.l == None else self.l | ||
| rr = 0 if self.r == None else abs(self.r) |
There was a problem hiding this comment.
Why abs is only used for self.r ?
There was a problem hiding this comment.
I hope that self.l > 0 and self.r < 0. It mean cut slice [self.l, self.len + r) of raw data.
you-n-g
reviewed
Feb 5, 2021
examples/highfreq/highfreq_ops.py
Outdated
| def __init__(self, feature, l=None, r=None): | ||
| self.l = l | ||
| self.r = r | ||
| if (self.l != None and self.l <= 0) or (self.r != None and self.r >= 0): | ||
| if (not self.l is None and self.l <= 0) or (not self.r is None and self.r >= 0): |
There was a problem hiding this comment.
The code is right, but it looks weird.
XXX is not YYYY is preferred than not XXX is YYYY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Highfreq Handler & Ops / Fix a Highfreq Bug
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes