Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move get_path to get_or_create_path, use the best model of SFM / TabNet #328

Merged
merged 2 commits into from Mar 11, 2021
Merged

Move get_path to get_or_create_path, use the best model of SFM / TabNet #328

merged 2 commits into from Mar 11, 2021

Conversation

D-X-Y
Copy link
Contributor

@D-X-Y D-X-Y commented Mar 11, 2021 •
edited

Description

  • The original save_path function is a little bit confused, thus refine it as a get_or_create_path function.
  • For SFM/TabNet, the model is evaluated by the last checkpoint not the best one according to validation.

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g you-n-g self-requested a review March 11, 2021 13:12
@you-n-g
Copy link
Collaborator

you-n-g commented Mar 11, 2021

Thanks to @D-X-Y. LGTM

@you-n-g you-n-g merged commit f6b019d into microsoft:main Mar 11, 2021
@D-X-Y
Copy link
Contributor Author

D-X-Y commented Mar 11, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you-n-g you-n-g Awaiting requested review from you-n-g

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@D-X-Y @you-n-g