Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Various Bugs for contrib.pytorch_ models #329

Merged
merged 5 commits into from Mar 12, 2021
Merged

Fix Various Bugs for contrib.pytorch_ models #329

merged 5 commits into from Mar 12, 2021

Conversation

D-X-Y
Copy link
Contributor

@D-X-Y D-X-Y commented Mar 12, 2021

There are some potential bugs in the implementation of PyTorch models in qlib

Description

  • use_gpu maybe True even if we did not use GPU
  • TabNet used "test set" during pre-training
  • TabNet used np.inf instead "-np.inf" for the initial best validation score
  • Given these bugs in TabNet, I temporarily remove the results of TabNet in README
  • Wrap torch.no_grad for evaluation procedures.
  • The old MLP models may skip the validation procedure.

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.

Types of changes

  • Fix bugs

@you-n-g
Copy link
Collaborator

you-n-g commented Mar 12, 2021

@D-X-Y Thanks for your contribution!

@you-n-g you-n-g merged commit 0cffb87 into microsoft:main Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants