Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existing parameter description #462

Merged
merged 1 commit into from Jun 8, 2021
Merged

Remove non-existing parameter description #462

merged 1 commit into from Jun 8, 2021

Conversation

arisliang
Copy link
Contributor

@arisliang arisliang commented Jun 8, 2021

Remove non-existing trade_exchange parameter description from generate_target_weight_position doc

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

Remove non-existing TradeExchange parameter from generate_target_weight_position doc
Copy link
Contributor

@Derek-Wds Derek-Wds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@you-n-g you-n-g merged commit ba021f6 into microsoft:main Jun 8, 2021
@arisliang arisliang deleted the patch-1 branch June 8, 2021 11:37
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
Remove non-existing parameter description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants