Make OnlineToolR more user-friendly and fix some bugs #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzh222333
changed the title
you-n-g
reviewed
Jun 23, 2021
qlib/workflow/recorder.py
Outdated
| with Path(path).open("rb") as f: | ||
| return pickle.load(f) | ||
| except OSError as e: | ||
| raise QlibException(message=str(e)) |
There was a problem hiding this comment.
This exception should be defined in the interface of Recorder
you-n-g
reviewed
Jun 23, 2021
you-n-g
reviewed
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make OnlineToolR more user-friendly and fix some bugs.
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes