Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set self.fitted = True instead of self._fitted. #478

Merged
merged 1 commit into from Jun 24, 2021

Conversation

topskychen
Copy link
Contributor

@topskychen topskychen commented Jun 24, 2021

All the current models are using fitted to indicate the model is fitted. Current _fitted should be a bug due to legacy code.

Description

Use self.fitted = True instead of self._fitted = True in pytorch_nn.py.

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g
Copy link
Collaborator

you-n-g commented Jun 24, 2021

@topskychen Thanks so much for fixing the bug!

@you-n-g you-n-g merged commit 2ab4a9a into microsoft:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants