Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI & add black formatter #51

Merged
merged 3 commits into from Oct 10, 2020
Merged

Update CI & add black formatter #51

merged 3 commits into from Oct 10, 2020

Conversation

Derek-Wds
Copy link
Contributor

Description

This PR adds the black format checker to the CI.

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@Derek-Wds Derek-Wds added the documentation Improvements or additions to documentation label Oct 9, 2020
@Derek-Wds Derek-Wds requested a review from you-n-g October 9, 2020 06:43
@@ -32,20 +32,18 @@ jobs:
- name: Install Lightgbm for MacOS
if: runner.os == 'macOS'
run: |
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
/bin/bash -c "$(curl -fsSL http://fintech.msra.cn/stock_data/downloads/brew_install.sh)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add link that depends on github will be better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will update it.

@you-n-g you-n-g merged commit 04fbe8d into microsoft:main Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants