Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat example data names: use {region}_data for 1-day data, and {region}_data_1min for 1-min data #781

Merged
merged 4 commits into from Dec 28, 2021

Conversation

cning112
Copy link
Contributor

Description

Use the same name for 1min data

Motivation and Context

The same data has two names, meaning the same data needs to be downloaded twice to run some examples.

How Has This Been Tested?

  • not needed

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@ghost
Copy link

ghost commented Dec 27, 2021

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ cning112 sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@you-n-g
Copy link
Collaborator

you-n-g commented Dec 27, 2021

@cning112 Thanks for your contribution.

I found a lot of commands with different format
image

Would you like to format them to the same path?
For example, qlib_cn_1min is a good name.

@you-n-g
Copy link
Collaborator

you-n-g commented Dec 27, 2021

Besides ...
image

Users from the community will be grateful to you :P

@cning112
Copy link
Contributor Author

sure, will make the change in the next commit. Thanks

@cning112
Copy link
Contributor Author

Actually I think the qlib_ prefix can be removed from the example data names. {region}_{freq} should suffice. What do you think? @you-n-g

@you-n-g
Copy link
Collaborator

you-n-g commented Dec 28, 2021

@cning112 Yes. Removing the redundant prefix make it simpler
Besides making it simpler, it will be better to make the name consistent with the previous directory to be compatible.
I think keeping "~/.qlib/qlib_data/cn_data" for 1-day data will be more friendly to old users

@you-n-g
Copy link
Collaborator

you-n-g commented Dec 28, 2021

@cning112 Please check the Paths in CI workflows
https://github.com/microsoft/qlib/tree/main/.github/workflows

Thanks

@cning112 cning112 changed the title Fix high-freq data name from yahoo_cn_1min to cn_data_1min Reformot example data names: use {region}_data for 1-day data, and {region}_data_1min for 1-min data Dec 28, 2021
@cning112 cning112 changed the title Reformot example data names: use {region}_data for 1-day data, and {region}_data_1min for 1-min data Reformat example data names: use {region}_data for 1-day data, and {region}_data_1min for 1-min data Dec 28, 2021
@you-n-g
Copy link
Collaborator

you-n-g commented Dec 28, 2021

It looks great! Thanks so much!

@you-n-g you-n-g merged commit 6bafd0a into microsoft:main Dec 28, 2021
@you-n-g you-n-g added the enhancement New feature or request label Jan 12, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
…`{region}_data_1min` for 1-min data (microsoft#781)

* Fix high-freq data name from `yahoo_cn_1min` to `cn_data_1min`

* re-format example data names using `qlib_{region}_{feq}`, e.g. qlib_cn_1d

* re-format example data names using `{region}_{feq}`, e.g. us_1d and cn_1min

* keep using  for 1day data, and change 1min data to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants