Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove hard code input dimension of model pytorch_tcts #843

Merged
merged 1 commit into from Jan 12, 2022

Conversation

PalanQu
Copy link
Contributor

@PalanQu PalanQu commented Jan 11, 2022

Description

Remove hard code input dimension of model pytorch_tcts

Motivation and Context

For the current time, the model ./qlib/contrib/model/pytorch_tcts.py can only fit the Alpha360 dataset, user usually has their own dataset.

How Has This Been Tested?

<! --- Put an x in all the boxes that apply: --->

  • [x ] Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • [ x] Add new feature
  • Update documentation

@you-n-g you-n-g added the enhancement New feature or request label Jan 12, 2022
@you-n-g
Copy link
Collaborator

you-n-g commented Jan 12, 2022

LGTM. Thanks!
Welcome to become one of Qlib's contributors

@you-n-g you-n-g merged commit 6f71f8a into microsoft:main Jan 12, 2022
@PalanQu PalanQu deleted the qujiabao/tcts branch January 12, 2022 11:26
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants