Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pit download_data script TypeError (#978) #979

Merged
merged 3 commits into from Mar 15, 2022
Merged

Fix pit download_data script TypeError (#978) #979

merged 3 commits into from Mar 15, 2022

Conversation

Chaoyingz
Copy link
Contributor

@Chaoyingz Chaoyingz commented Mar 14, 2022 •
edited

Fix pit download_data script TypeError (#978)

Description

See #978.

Motivation and Context

How Has This Been Tested?

<! --- Put an x in all the boxes that apply: --->

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:
    image

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@ghost
Copy link

ghost commented Mar 14, 2022 •
edited by ghost

CLA assistant check
All CLA requirements met.

@Chaoyingz Chaoyingz mentioned this pull request Mar 14, 2022
Closed
@you-n-g
Copy link
Collaborator

you-n-g commented Mar 15, 2022

Thanks so much!

1 similar comment
@you-n-g
Copy link
Collaborator

you-n-g commented Mar 15, 2022

Thanks so much!

@you-n-g you-n-g merged commit 5f18ba7 into microsoft:main Mar 15, 2022
@you-n-g you-n-g added bug Something isn't working enhancement New feature or request labels Apr 24, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@Chaoyingz
Fix pit download_data script TypeError (microsoft#978) (microsoft#979)
104c88b 
* Fix pit download_data script TypeError (microsoft#978)

* Format pit collector with black

* Format pit collector with black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Chaoyingz @you-n-g