This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Update to Fantomas 4.6.5 #1374
Merged
Update to Fantomas 4.6.5 #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Fantomas version has bug fixes that let us remove our
.fantomasignorefile (which was ignoring .fsi files and some of the transformation class definitions due to comments previously being eaten and crashes).It also introduces some new bugs, but they are minor cosmetic issues:
breakandvirtual: Keep backticks in identifiers fsprojects/fantomas#2034. This causes an F# warning, but I suppressed the warnings for the files affected.basewhen calling a base class method, but this seems to be harmless.