Output receiver for dumping state #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
requested review from
idavis,
bamarsha,
billti and
minestarks
as code owners
billti
reviewed
Mar 28, 2023
| .expect("writing to string should succeed"); | ||
| let (last, most) = state | ||
| .split_last() | ||
| .expect("state should always have at least one entry"); |
There was a problem hiding this comment.
Not sure I follow why you are splitting this and writing the last separately. Can you clarify?
There was a problem hiding this comment.
the last one doesn't get a comma :). It's just a silly way of handling the manual conversion to JSON. The nice part about this division is that the Receiver will get called with the Rust structures, and then it's totally up to the code in the wasm level to decide how it wants to serialize that.
billti
approved these changes
Mar 28, 2023
|
I have one more change I want to update quickly to make it easier to use, then I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.