Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds task 1.13 to Superposition Kata #1382

Merged
merged 19 commits into from
Apr 22, 2024

Conversation

frtibble
Copy link
Contributor

Part of #1185

@tcNickolas
Copy link
Member

Let me know when this is ready for review!

@frtibble frtibble marked this pull request as ready for review April 18, 2024 17:28
@frtibble
Copy link
Contributor Author

Thank you @jkingdon-ms for the helpful feedback, @tcNickolas tagging you as it is ready for review!

Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has quite a few build errors that CI build doesn't catch because this kata is not added to the katas/content/index.json file. We usually add this kata to the index when we work on it, so that it shows up in local tests and playground for us to play with and the CI build can verify it, and then in the very last iteration remove it so that it doesn't get published prematurely.

Thank you!

@tcNickolas
Copy link
Member

The CI build still fails. Did you try to build the new task locally in the playground? This helps to figure our build issues a lot

@frtibble
Copy link
Contributor Author

Hi Mariia, I've pushed a few more changes now which hopefully address the remaining comments, let me know if anything needs tweaking

Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, only few minor edits!

Thank you!

katas/content/superposition/four_bitstrings/index.md Outdated Show resolved Hide resolved
katas/content/superposition/four_bitstrings/index.md Outdated Show resolved Hide resolved
katas/content/superposition/index.md Outdated Show resolved Hide resolved
katas/content/superposition/four_bitstrings/solution.md Outdated Show resolved Hide resolved
katas/content/superposition/four_bitstrings/solution.md Outdated Show resolved Hide resolved
katas/content/index.json Outdated Show resolved Hide resolved
@tcNickolas tcNickolas added this pull request to the merge queue Apr 22, 2024
Merged via the queue into microsoft:main with commit a001a09 Apr 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants