Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Adaptive RI profile #1451

Merged
merged 1 commit into from
May 3, 2024
Merged

Adding Adaptive RI profile #1451

merged 1 commit into from
May 3, 2024

Conversation

idavis
Copy link
Collaborator

@idavis idavis commented Apr 30, 2024

No description provided.

@idavis idavis self-assigned this Apr 30, 2024
Copy link

Benchmark for 8b6d216

Click to view benchmark
Test Base PR %
Array append evaluation 343.8±13.06µs 343.8±3.88µs 0.00%
Array literal evaluation 174.1±2.62µs 192.7±2.46µs +10.68%
Array update evaluation 423.9±7.86µs 425.8±2.93µs +0.45%
Core + Standard library compilation 18.1±0.79ms 18.6±1.01ms +2.76%
Deutsch-Jozsa evaluation 5.1±0.07ms 5.1±0.05ms 0.00%
Large file parity evaluation 33.7±0.12ms 33.8±0.31ms +0.30%
Large input file compilation 11.7±0.64ms 12.1±0.48ms +3.42%
Large input file compilation (interpreter) 44.5±1.75ms 49.3±1.56ms +10.79%
Large nested iteration 33.6±1.25ms 33.8±0.25ms +0.60%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1498.5±32.26µs 1536.7±130.29µs +2.55%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.7±0.08ms 7.9±0.13ms +2.60%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1420.5±72.26µs 1431.6±54.63µs +0.78%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.1±0.13ms 21.5±0.23ms +1.90%
Teleport evaluation 82.5±4.09µs 83.0±4.33µs +0.61%

@idavis idavis marked this pull request as ready for review April 30, 2024 22:51
pip/qsharp/_native.pyi Outdated Show resolved Hide resolved
@idavis idavis force-pushed the iadavis/adaptiveri-profile branch from 5e61cce to a9c5a2d Compare May 1, 2024 12:20
@idavis idavis enabled auto-merge May 1, 2024 12:26
Copy link

github-actions bot commented May 1, 2024

Benchmark for fed14e2

Click to view benchmark
Test Base PR %
Array append evaluation 354.6±3.01µs 347.2±6.29µs -2.09%
Array literal evaluation 192.3±0.84µs 173.5±1.57µs -9.78%
Array update evaluation 440.9±2.19µs 431.0±1.81µs -2.25%
Core + Standard library compilation 16.7±0.23ms 17.0±0.52ms +1.80%
Deutsch-Jozsa evaluation 5.1±0.05ms 5.1±0.06ms 0.00%
Large file parity evaluation 33.7±0.14ms 33.5±0.29ms -0.59%
Large input file compilation 11.3±0.09ms 11.8±0.66ms +4.42%
Large input file compilation (interpreter) 43.2±1.17ms 45.2±2.57ms +4.63%
Large nested iteration 35.9±0.25ms 34.6±1.84ms -3.62%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1494.1±27.52µs 1487.3±30.44µs -0.46%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.6±0.07ms 7.6±0.10ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1413.8±46.22µs 1406.2±38.69µs -0.54%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.1±0.16ms 21.2±0.25ms +0.47%
Teleport evaluation 82.3±4.16µs 81.7±4.08µs -0.73%

@idavis idavis disabled auto-merge May 1, 2024 14:51
@minestarks
Copy link
Member

How will the user know to associate the phrase "Adaptive RI" with the Quantinuum target?

Copy link
Member

@minestarks minestarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as we figure out what to do with the documentation.

@idavis idavis added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit adc0514 May 3, 2024
17 checks passed
@idavis idavis deleted the iadavis/adaptiveri-profile branch May 3, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants