New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check unresolved callables during partial eval #1497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the RCA check pass to not treat unresolved callables as errors and instead relies on a new check at partial eval time that checks the resolved callable with the known arguments to return RCA check errors at that point.
64 tasks
Benchmark for 8ff8b98Click to view benchmark
|
Benchmark for 4b8418eClick to view benchmark
|
Benchmark for 21a9106Click to view benchmark
|
Benchmark for 071746fClick to view benchmark
|
cesarzc
reviewed
May 13, 2024
cesarzc
approved these changes
May 13, 2024
…unresolved-call-check
Benchmark for c88d3aaClick to view benchmark
|
idavis
approved these changes
May 13, 2024
Benchmark for d09adedClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the RCA check pass to not treat unresolved callables as errors and instead relies on a new check at partial eval time that checks the resolved callable with the known arguments to return RCA check errors at that point.