Teleportation Task 1.2-1.4 added #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devikamehra
requested review from
billti,
cesarzc,
DmitryVasilevsky,
sezna,
swernli and
tcNickolas
as code owners
tcNickolas
requested changes
May 23, 2024
katas/content/teleportation/standard_teleportation_protocol/index.md
Outdated
Show resolved
Hide resolved
|
Additionally, please add the kata you're working on to index.json, so that CI builds can verify it |
tcNickolas
requested changes
May 30, 2024
katas/content/teleportation/standard_teleportation_protocol/Placeholder.qs
Outdated
Show resolved
Hide resolved
katas/content/teleportation/standard_teleportation_protocol/index.md
Outdated
Show resolved
Hide resolved
tcNickolas
approved these changes
May 30, 2024
There was a problem hiding this comment.
Looks good! I spent some time thinking about the best way to show the results to the learner; you were right that we can't avoid DumpMachine for all scenarios, but then we need to explain what the learner sees in the output. I left a suggestion for that, let me apply it and send this on its way to merge.
Thank you!
katas/content/teleportation/standard_teleportation_protocol/Verification.qs
Outdated
Show resolved
Hide resolved
tcNickolas
reviewed
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teleportation Task 1.2-1.4 added