Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop FIR increment if FIR passes fail #1559

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

swernli
Copy link
Collaborator

@swernli swernli commented May 22, 2024

This fixes an issue with incremental compilation where an increment with a failure could still have that FIR present in the package during later compilation, making errors "sticky" instead of associated with just the increment. This achieves it by tracking what the most recently lowered additions to the package were and removing them if there were pass failures like those from RCA check.

This fixes an issue with incremental compilation where an increment with a failure could still have that FIR present in the package during later compilation, making errors "sticky" instead of associated with just the increment. This achieves it by tracking what the most recently lowered additions to the package were and removing them if there were pass failures like those from RCA check.
Copy link

Benchmark for 5960c82

Click to view benchmark
Test Base PR %
Array append evaluation 327.3±4.45µs 331.6±1.17µs +1.31%
Array literal evaluation 175.9±1.00µs 176.7±1.19µs +0.45%
Array update evaluation 408.5±1.50µs 411.5±1.67µs +0.73%
Core + Standard library compilation 19.3±0.23ms 18.8±0.25ms -2.59%
Deutsch-Jozsa evaluation 5.0±0.04ms 5.1±0.24ms +2.00%
Large file parity evaluation 34.1±0.32ms 34.0±0.26ms -0.29%
Large input file compilation 12.8±0.14ms 12.6±0.37ms -1.56%
Large input file compilation (interpreter) 48.1±0.70ms 46.8±0.79ms -2.70%
Large nested iteration 32.4±0.47ms 32.6±0.12ms +0.62%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1563.5±34.79µs 1566.1±32.01µs +0.17%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.8±0.08ms 7.9±0.10ms +1.28%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1425.6±38.50µs 1427.4±44.03µs +0.13%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 28.2±0.36ms 28.0±0.14ms -0.71%
Teleport evaluation 87.5±3.91µs 89.5±4.56µs +2.29%

@swernli swernli requested a review from billti as a code owner May 22, 2024 19:50
Copy link

Benchmark for a1ac4e7

Click to view benchmark
Test Base PR %
Array append evaluation 326.0±1.65µs 326.8±4.78µs +0.25%
Array literal evaluation 190.4±1.54µs 189.9±1.55µs -0.26%
Array update evaluation 409.5±4.67µs 410.1±4.51µs +0.15%
Core + Standard library compilation 22.0±0.91ms 20.7±1.20ms -5.91%
Deutsch-Jozsa evaluation 5.0±0.07ms 5.1±0.10ms +2.00%
Large file parity evaluation 33.9±0.08ms 34.2±0.45ms +0.88%
Large input file compilation 14.7±0.64ms 13.1±0.32ms -10.88%
Large input file compilation (interpreter) 51.7±1.75ms 49.2±0.86ms -4.84%
Large nested iteration 32.9±0.87ms 32.5±0.22ms -1.22%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1618.2±151.11µs 1592.7±130.70µs -1.58%
Perform Runtime Capabilities Analysis (RCA) on large file sample 8.3±0.19ms 7.9±0.11ms -4.82%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1472.6±151.93µs 1431.8±48.40µs -2.77%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 29.3±0.28ms 28.1±0.44ms -4.10%
Teleport evaluation 87.1±5.20µs 88.1±4.23µs +1.15%

Copy link

Benchmark for 626eb8d

Click to view benchmark
Test Base PR %
Array append evaluation 326.0±1.66µs 333.9±1.46µs +2.42%
Array literal evaluation 189.7±0.68µs 192.2±0.60µs +1.32%
Array update evaluation 409.1±1.95µs 416.1±1.38µs +1.71%
Core + Standard library compilation 18.4±0.31ms 18.5±0.23ms +0.54%
Deutsch-Jozsa evaluation 5.0±0.04ms 5.0±0.04ms 0.00%
Large file parity evaluation 33.8±0.07ms 33.9±0.34ms +0.30%
Large input file compilation 12.3±0.11ms 12.4±0.25ms +0.81%
Large input file compilation (interpreter) 45.2±0.89ms 45.4±0.92ms +0.44%
Large nested iteration 32.3±0.18ms 33.0±0.18ms +2.17%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1551.0±38.48µs 1559.0±68.32µs +0.52%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.7±0.42ms 7.7±0.09ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1408.7±25.49µs 1412.2±30.31µs +0.25%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 27.9±0.28ms 27.8±0.50ms -0.36%
Teleport evaluation 87.0±4.27µs 87.5±3.77µs +0.57%

@swernli swernli added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 16ee14b May 22, 2024
16 checks passed
@swernli swernli deleted the swernli/drop-fir-increment-on-fail branch May 22, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants