Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust 1.78 #1570

Merged
merged 4 commits into from
May 24, 2024
Merged

Update to Rust 1.78 #1570

merged 4 commits into from
May 24, 2024

Conversation

orpuente-MS
Copy link
Contributor

@orpuente-MS orpuente-MS commented May 24, 2024

This updates the versions in our build and release pipelines to use Rust 1.78 and fixes a new clippy warning generated by the new rust version

prereqs.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link

Benchmark for 9656a80

Click to view benchmark
Test Base PR %
Array append evaluation 349.1±13.35µs 347.8±6.44µs -0.37%
Array literal evaluation 200.1±3.45µs 205.9±5.66µs +2.90%
Array update evaluation 437.0±13.20µs 434.0±6.26µs -0.69%
Core + Standard library compilation 20.8±0.91ms 21.2±0.86ms +1.92%
Deutsch-Jozsa evaluation 5.5±0.09ms 5.5±0.08ms 0.00%
Large file parity evaluation 36.8±0.91ms 36.9±0.56ms +0.27%
Large input file compilation 14.3±1.01ms 14.5±0.66ms +1.40%
Large input file compilation (interpreter) 60.4±4.50ms 55.3±4.54ms -8.44%
Large nested iteration 33.9±0.43ms 34.3±0.35ms +1.18%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1693.2±64.95µs 1720.4±60.17µs +1.61%
Perform Runtime Capabilities Analysis (RCA) on large file sample 8.7±0.35ms 9.0±0.39ms +3.45%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1521.9±68.17µs 1566.6±115.81µs +2.94%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 30.2±0.52ms 30.8±1.05ms +1.99%
Teleport evaluation 94.5±4.74µs 96.7±4.37µs +2.33%

@billti
Copy link
Member

billti commented May 24, 2024

Drop a note to the team when this merges to update. (I was still on 1.77)

Co-authored-by: Stefan J. Wernli <swernli@microsoft.com>
Copy link

Benchmark for 3c24074

Click to view benchmark
Test Base PR %
Array append evaluation 331.9±1.57µs 331.8±2.59µs -0.03%
Array literal evaluation 192.7±0.86µs 192.5±0.56µs -0.10%
Array update evaluation 414.8±11.13µs 415.5±13.07µs +0.17%
Core + Standard library compilation 18.6±0.54ms 18.6±0.24ms 0.00%
Deutsch-Jozsa evaluation 5.2±0.06ms 5.2±0.06ms 0.00%
Large file parity evaluation 34.1±0.10ms 34.2±0.22ms +0.29%
Large input file compilation 12.6±0.34ms 12.8±0.43ms +1.59%
Large input file compilation (interpreter) 45.4±0.78ms 46.6±1.71ms +2.64%
Large nested iteration 32.6±0.27ms 33.5±1.21ms +2.76%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1559.3±37.60µs 1573.0±82.80µs +0.88%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.8±0.14ms 7.7±0.07ms -1.28%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1412.8±29.54µs 1425.6±70.90µs +0.91%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 28.2±0.18ms 28.4±0.22ms +0.71%
Teleport evaluation 92.1±5.21µs 91.8±3.64µs -0.33%

@orpuente-MS orpuente-MS added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit 6bed5a9 May 24, 2024
16 checks passed
@orpuente-MS orpuente-MS deleted the oscarpuente/update-rust-version branch May 24, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants