Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read correct field in QEC scheme #1602

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Read correct field in QEC scheme #1602

merged 1 commit into from
Jun 3, 2024

Conversation

msoeken
Copy link
Member

@msoeken msoeken commented Jun 1, 2024

The wrong field is read to calculate the physical number of qubits for a QEC scheme.

Copy link

github-actions bot commented Jun 1, 2024

Benchmark for 4ae961f

Click to view benchmark
Test Base PR %
Array append evaluation 336.6±2.96µs 331.9±1.49µs -1.40%
Array literal evaluation 173.8±5.93µs 188.8±0.92µs +8.63%
Array update evaluation 409.0±1.16µs 410.3±4.00µs +0.32%
Core + Standard library compilation 18.5±0.12ms 18.5±0.09ms 0.00%
Deutsch-Jozsa evaluation 5.0±0.05ms 5.1±0.08ms +2.00%
Large file parity evaluation 34.1±0.08ms 34.2±0.07ms +0.29%
Large input file compilation 12.1±0.14ms 12.1±0.14ms 0.00%
Large input file compilation (interpreter) 45.0±0.58ms 45.1±0.51ms +0.22%
Large nested iteration 32.8±0.25ms 32.6±0.21ms -0.61%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1555.4±32.73µs 1553.6±29.45µs -0.12%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.6±0.09ms 7.7±0.07ms +1.32%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1413.7±30.84µs 1414.0±29.01µs +0.02%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 27.7±0.12ms 27.7±0.15ms 0.00%
Teleport evaluation 88.8±3.64µs 90.6±8.68µs +2.03%

Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any test updates that should come with this?

@msoeken
Copy link
Member Author

msoeken commented Jun 3, 2024

Are there any test updates that should come with this?

No test needed to be updated.

@msoeken msoeken added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 7c401d0 Jun 3, 2024
16 checks passed
@msoeken msoeken deleted the msoeken/re-ftp-fix branch June 3, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants