Fuzzing #168
Merged
Fuzzing #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzminrobin
force-pushed
the
kuzminrobin/fuzz
branch
3 times, most recently
from
3262646
to
c552f13
Compare
bamarsha
reviewed
Apr 24, 2023
kuzminrobin
force-pushed
the
kuzminrobin/fuzz
branch
from
c552f13
to
b752836
Compare
swernli
reviewed
Apr 25, 2023
swernli
reviewed
Apr 25, 2023
swernli
reviewed
Apr 25, 2023
swernli
reviewed
Apr 25, 2023
swernli
reviewed
Apr 25, 2023
kuzminrobin
force-pushed
the
kuzminrobin/fuzz
branch
from
b752836
to
2f3ef59
Compare
|
I addressed the feedback. Please review the updates while I'm working on |
billti
reviewed
May 4, 2023
billti
reviewed
May 4, 2023
billti
reviewed
May 4, 2023
billti
reviewed
May 4, 2023
billti
reviewed
May 4, 2023
kuzminrobin
force-pushed
the
kuzminrobin/fuzz
branch
from
2f3ef59
to
5f0bf82
Compare
|
Please review. |
billti
reviewed
May 9, 2023
swernli
reviewed
May 9, 2023
There was a problem hiding this comment.
I really like the smaller seed input as opposed to the large folder of corpus samples!
A few snippets I noticed are not present in there, some of which are new syntax and some of which are existing:
- while loops are not present
- Returning values from if-statements, as in
let x = if cond_var { 3 } else { 4 };- repeat-loop without a fixup block
- return or fail used as nested expressions instead of just as block-level statements
- ternary update expression outside of assign-update, ie:
let x = array w/ index <- value;
There are probably more, but those few jumped to the top of my head as things we might want to include so fuzzing has a change to reuse them in other places.
kuzminrobin
force-pushed
the
kuzminrobin/fuzz
branch
from
3fb3a65
to
efc00a3
Compare
|
Please review again. |
billti
reviewed
May 9, 2023
swernli
reviewed
May 10, 2023
swernli
previously requested changes
May 10, 2023
billti
reviewed
May 10, 2023
billti
reviewed
May 10, 2023
kuzminrobin
force-pushed
the
kuzminrobin/fuzz
branch
from
f358773
to
4b4b524
Compare
swernli
reviewed
May 11, 2023
kuzminrobin
force-pushed
the
kuzminrobin/fuzz
branch
from
32923ab
to
3d4c6f1
Compare
swernli
reviewed
May 13, 2023
swernli
reviewed
May 13, 2023
kuzminrobin
force-pushed
the
kuzminrobin/fuzz
branch
from
0a1467c
to
ec4229c
Compare
swernli
approved these changes
May 15, 2023
swernli
reviewed
May 15, 2023
swernli
reviewed
May 15, 2023
swernli
reviewed
May 15, 2023
CR change.
Cleanup.
Stefan's proposed changes.
Exclusded fuzzing from defaults.
Update after rebase.
. . .
Renamed fuzz target.
Added readme section, minor clean-up.
Initial merge of the compiler fuzzing.
kuzminrobin
force-pushed
the
kuzminrobin/fuzz
branch
from
f320dab
to
9b66fdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fuzzing and code coverage during it to the repo.
Fixes #169, #257.