-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error patterns #194
Conversation
The question came up in further discussion having a more specific convention in the error messages. Specifically, treat the top-level message (the thing in |
This change updates the error patterns in the compiler to favor only using labels with strings that add more information to the top level error message and make sense when concatenated. It also updates the `qsc_wasm` error translation to use the label message and help text if present. Note this updates the `Ambiguous` error to use a single span by referring to other namespaces by name rather than position.
8f8fafe
to
84c9c9f
Compare
This change updates the error patterns in the compiler to favor only using labels with strings that add more information to the top level error message and make sense when concatenated. It also updates the
qsc_wasm
error translation to use the label message and help text if present.