Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse internal for callable declarations #21

Merged
merged 5 commits into from
Feb 18, 2023
Merged

Parse internal for callable declarations #21

merged 5 commits into from
Feb 18, 2023

Conversation

bamarsha
Copy link
Contributor

This allows you to declare internal callables. Also includes two small bug fixes for open items and array expressions.

swernli
swernli approved these changes Feb 18, 2023
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise looks good.

compiler/qsc_frontend/src/parse/top.rs Show resolved Hide resolved
@bamarsha bamarsha merged commit 5b0a424 into main Feb 18, 2023
@bamarsha bamarsha deleted the samarsha/internal branch February 18, 2023 05:09
@swernli swernli mentioned this pull request Mar 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swernli swernli swernli approved these changes

@idavis idavis Awaiting requested review from idavis idavis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bamarsha @swernli