Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce examples to katas #261

Merged
merged 21 commits into from
May 5, 2023
Merged

Introduce examples to katas #261

merged 21 commits into from
May 5, 2023

Conversation

cesarzc
Copy link
Contributor

@cesarzc cesarzc commented May 2, 2023

This change introduces the concept of examples to katas.

@cesarzc cesarzc marked this pull request as ready for review May 3, 2023 00:41
minestarks
minestarks approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@minestarks minestarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some style feedback. Not too confident reviewing the Rust parts.

katas/content/qubit/qubit_data_type/content.md Outdated Show resolved Hide resolved
playground/src/katas.ts Outdated Show resolved Hide resolved
playground/src/katas.ts Outdated Show resolved Hide resolved
playground/src/katas.ts Outdated Show resolved Hide resolved
playground/src/katas.ts Outdated Show resolved Hide resolved
playground/src/katas.ts Outdated Show resolved Hide resolved
playground/src/katas.ts Outdated Show resolved Hide resolved
playground/src/main.ts Outdated Show resolved Hide resolved
swernli
swernli approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback on text (minor because I know we are going to iterate and refine text as an ongoing effort).

@cesarzc cesarzc merged commit 7bf21cd into main May 5, 2023
10 checks passed
@cesarzc cesarzc deleted the cesarzc/introduce-examples-to-katas branch May 5, 2023 00:05
@cesarzc cesarzc mentioned this pull request May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swernli swernli swernli approved these changes

@minestarks minestarks minestarks approved these changes

@billti billti Awaiting requested review from billti billti is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cesarzc @swernli @minestarks