Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lexer #4

Merged
merged 31 commits into from
Feb 10, 2023
Merged

Add lexer #4

merged 31 commits into from
Feb 10, 2023

Conversation

bamarsha
Copy link
Contributor

@bamarsha bamarsha commented Feb 8, 2023 •
edited

The lexer supports everything except interpolated strings.

swernli
swernli reviewed Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback here. Overall, I love the design and the tests infra! Agreed that more comments are needed before this is fully ready, and I'd also like to see test cases for all the tokens that are specifically handled (I know, it's a lot).

compiler/qsc_frontend/src/lex/raw.rs Show resolved Hide resolved
compiler/qsc_frontend/src/lex/raw.rs Show resolved Hide resolved
compiler/qsc_frontend/src/lex/cooked.rs Show resolved Hide resolved
compiler/qsc_frontend/src/lex/cooked.rs Outdated Show resolved Hide resolved
@bamarsha bamarsha marked this pull request as ready for review February 10, 2023 19:28
swernli
swernli reviewed Feb 10, 2023
View reviewed changes
compiler/qsc_frontend/src/lex/cooked.rs Outdated Show resolved Hide resolved
compiler/qsc_frontend/src/lex/cooked.rs Outdated Show resolved Hide resolved
@swernli swernli merged commit f67759b into main Feb 10, 2023
@swernli swernli deleted the samarsha/lexer branch February 10, 2023 23:14
@swernli swernli mentioned this pull request Mar 9, 2023
Closed
swernli added a commit that referenced this pull request Dec 6, 2023
@swernli
Merge pull request #4 from swernli/swernli/re-obf
c47b60b 
Add RE stubs and placeholders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idavis idavis idavis left review comments

@swernli swernli swernli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bamarsha @idavis @swernli