Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support package dependencies #46

Merged
merged 24 commits into from
Mar 8, 2023
Merged

Support package dependencies #46

merged 24 commits into from
Mar 8, 2023

Conversation

bamarsha
Copy link
Contributor

@bamarsha bamarsha commented Mar 6, 2023 •
edited

  • Create PackageStore so that external packages can be accessed during compilation.
  • compile accepts a list of package IDs to use as dependencies. Public globals from these packages will be considered during name resolution.
  • In the resolutions table, include the package ID of paths that resolve to an external package.

Sarah Marshall added 22 commits March 5, 2023 20:43
@bamarsha bamarsha marked this pull request as ready for review March 7, 2023 22:55
@bamarsha bamarsha requested review from swernli and idavis March 7, 2023 22:58
swernli
swernli reviewed Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done reviewing, but posting what I have to start discussion.

compiler/qsc_frontend/src/resolve.rs Outdated Show resolved Hide resolved
@bamarsha bamarsha enabled auto-merge (squash) March 8, 2023 22:09
@bamarsha bamarsha merged commit 756ce00 into main Mar 8, 2023
@bamarsha bamarsha deleted the samarsha/deps branch March 8, 2023 22:13
@bamarsha bamarsha mentioned this pull request Mar 9, 2023
Merged
bamarsha added a commit that referenced this pull request Mar 9, 2023
@bamarsha
Clean up naming for DefId variables (#59)
7228779 
When I renamed `Res` to `DefId` before merging #46, I forgot to update
the names of variables that are now of type `DefId`.
@swernli swernli mentioned this pull request Mar 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swernli swernli swernli approved these changes

@idavis idavis Awaiting requested review from idavis idavis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bamarsha @swernli