Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample circuit is incorrectly rendered #17

Closed
theRoughCode opened this issue May 31, 2021 · 2 comments · Fixed by #60
Closed

Sample circuit is incorrectly rendered #17

theRoughCode opened this issue May 31, 2021 · 2 comments · Fixed by #60
Assignees
@aaronthangnguyen
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest Good for Hacktoberfest participants

Comments

@theRoughCode
Copy link
Collaborator

The sample circuit is incorrectly rendered such that the operation Foo is already expanded on first render. Furthermore, hovering over the group shows a + icon instead of -.

We should investigate this behaviour and fix it.

image
@theRoughCode theRoughCode added the bug Something isn't working label May 31, 2021
@anpaz
Copy link
Member

anpaz commented Jun 4, 2021

This is a problem on how we keep track of what things are/should be expanded.
On one side, we use the GateType.Group to decide if it should be rendered as a box, on the other hand we use the data-attribute 'expanded' to decided whether a to show the expanded/contracted icon. This should be simplified/consolidated.

@anpaz anpaz added the good first issue Good for newcomers label Jun 4, 2021
@jond01 jond01 mentioned this issue Jul 6, 2021
Closed
@guenp guenp added the Hacktoberfest Good for Hacktoberfest participants label Sep 20, 2021
@mqnguyen5
Copy link

Hi, I would like to give this a try if possible. Since I'm pretty new to contributing, where should I start?

@aaronthangnguyen aaronthangnguyen mentioned this issue May 19, 2022
Merged
10 tasks
@anpaz anpaz closed this as completed in #60 May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronthangnguyen aaronthangnguyen

Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest Good for Hacktoberfest participants
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix zoom button rendering when ConditionalRender.AsGroup microsoft/quantum-viz.js
5 participants
@guenp @theRoughCode @anpaz @aaronthangnguyen @mqnguyen5