Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing a parent operation leaves the children closed with a minus (-) sign #34

Closed
jond01 opened this issue Jul 6, 2021 · 0 comments · Fixed by #56
Closed

Closing a parent operation leaves the children closed with a minus (-) sign #34

jond01 opened this issue Jul 6, 2021 · 0 comments · Fixed by #56
Assignees
Labels
good first issue Good for newcomers Hacktoberfest Good for Hacktoberfest participants

Comments

@jond01
Copy link
Contributor

jond01 commented Jul 6, 2021

Describe the bug
When there is a nested circuit - an operation within an operation, and both are open, closing the top operation keeps the inner one semi-open.
After reopening the top operation, the inner one is with a minus sign (-) - as an open operation, but it is actually closed.

To Reproduce
Steps to reproduce the behavior:

  1. Open the example in the repository, also here:
    https://observablehq.com/@anpaz/quantum?ui=classic
    Specifically, focus on the last example (Grover search).
  2. Click on the plus (+) of the first "GroverIteration (Oracle)" operation.
  3. Keep the previous operation open and close the topmost "GroverSearch" operation.
  4. Open the top operation. The previously opened operation is closed but presented with a minus (-).

Expected behavior
I would expect one of the two:

  1. Closing with children reset: closing a parent (or a grandparent) closes all its children and indirect grand-children. Reopening the parent appropriately presents the children closed with a (+) sign.
  2. Closing with memory: when closing and reopening a parent operation, the previous state of its children is kept intact. In the above example, "GroverIteration (Oracle)" should be visually open at step 4.

Screenshots

  1. image
  2. image
  3. image
  4. image

Edit:
This issue is connected to #17.

@anpaz anpaz added the good first issue Good for newcomers label Aug 21, 2021
@guenp guenp added the Hacktoberfest Good for Hacktoberfest participants label Sep 20, 2021
@anpaz anpaz closed this as completed in #56 May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest Good for Hacktoberfest participants
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants