Fixing multi-root-joins #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amdawood
reviewed
Jul 10, 2023
amdawood
previously approved these changes
Jul 10, 2023
amdawood
approved these changes
Jul 10, 2023
nilay-kapadia
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue appeared to be that the previous join clauses were passed into the Join statements, which then tried to re-add a previously added clause.
To avoid this, I've changed the JoinQuery to pass new JoinWithStatements into each Join invocation rather than maintaining a single statement for the life of the JoinQuery.
Closes #34