Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Top Domains List #16

Closed
nibanks opened this issue Apr 26, 2022 · 6 comments · Fixed by #31
Closed

Update Top Domains List #16

nibanks opened this issue Apr 26, 2022 · 6 comments · Fixed by #31
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nibanks
Copy link
Member

nibanks commented Apr 26, 2022

The current list is a few years out of date. It'd be great if we could update to something more recent.
@nibanks nibanks added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 26, 2022
@davinci26
Copy link
Contributor

Is there a reason for having google|amazon under different domain extensions? Seems that it biases results a bit.

How about using this one https://majestic.com/reports/majestic-million?s=0 ? and pick top X (1k, 5k)?

@nibanks
Copy link
Member Author

nibanks commented Jun 16, 2022

I simply copied a list I found. I'm perfectly happy updating to a new list. Feel free to send a PR updating the code! 😁

@davinci26
Copy link
Contributor

Will update the list with a PR

First a question as I am validating stufff:

Does HandshakeSuccess mean that the domain that can be reached via quic or do you have h2/h1 fallback and this means that domain is reachable in some way?

@nibanks
Copy link
Member Author

nibanks commented Jun 17, 2022

This entirely QUIC and HTTP/3. No fallback.

@davinci26
Copy link
Contributor

The reason I am asking is that there is a domain I know that it doesnt do h3 but it is marked like it can so trying to understand in more detail how quicreach works and what is going on.

Also is it correct that you dont do the entire http request, you just attempt to do a QUIC handshake and if the server connects then on each attempt from the server to open a stream for that connection you close it.

@nibanks
Copy link
Member Author

nibanks commented Jun 17, 2022

I'm just doing the QUIC handshake, no real HTTP protocol beyond that.

davinci26 added a commit to davinci26/quicreach that referenced this issue Jun 17, 2022
@davinci26
Updates domains list and prints if quic is supported
db4f3e6 
Updates the list of domains and fixes microsoft#16

Also added in the print statement a column that prints 'yes' or 'no'
if QUIC is supported which allows for easier grepping for the output.

So if you wanted to see all the domains that support quic

`quicreach '*' -s | grep yes` (havent discussed about this change so if
you dont want it let me know I will revert it)

Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com>
@davinci26 davinci26 mentioned this issue Jun 17, 2022
Merged
nibanks pushed a commit that referenced this issue Jun 17, 2022
Updates domains list (#31)
5ba17a2 
Updates the list of domains and fixes #16

Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates domains list davinci26/quicreach
2 participants
@nibanks @davinci26