Merge pull request #78 from Microsoft/delete-old-package-error

Prevent error in deleting old packages from failing the install operation.
microsoft · Nov 29, 2015 · d25489c · d25489c
2 parents eeb4901 + 1a7a955
commit d25489c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/CodePushPackage.m b/CodePushPackage.m
@@ -221,9 +221,11 @@ + (void)installPackage:(NSDictionary *)updatePackage
     NSString *previousPackageHash = [self getPreviousPackageHash:error];
     if (!*error && previousPackageHash && ![previousPackageHash isEqualToString:packageHash]) {
         NSString *previousPackageFolderPath = [self getPackageFolderPath:previousPackageHash];
-        [[NSFileManager defaultManager] removeItemAtPath:previousPackageFolderPath error:error];
-        if (*error) {
-            return;
+        // Error in deleting old package will not cause the entire operation to fail.
+        NSError *deleteError;
+        [[NSFileManager defaultManager] removeItemAtPath:previousPackageFolderPath error:&deleteError];
+        if (deleteError) {
+            NSLog(@"Error deleting old package: %@", deleteError);
         }
     }