You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I specifically set --output-dir . as I want to upload the resulting bundle and sourcemap to Bugsnag. I expect, after running release-react command to find the binary bundle and the sourcemap in current directory.
Actual Behavior
CodePush creates a CodePush directory in current directory, where I can find the JS bundle and sourcemap (index.android.bundle and index.android.bundle.map), the binary sourcemap (index.android.bundle.hbc.map) but no binary bundle (which I expect to be index.android.bundle.hbc).
I watched the directory, as CodePush was creating the bundles, and I saw that the file gets created but disappears immediately (moved/deleted?), possibly when starting the upload. These are the logs:
Running "react-native bundle" command:
node node_modules/.bin/react-native bundle --assets-dest CodePush --bundle-output CodePush/index.android.bundle --dev false --entry-file index.js --platform android --sourcemap-output CodePush/index.android.bundle.map
Welcome to React Native!
Learn once, write anywhere
info Writing bundle output to:, CodePush/index.android.bundle
info Writing sourcemap output to:, CodePush/index.android.bundle.map
info Done writing bundle output
info Done writing sourcemap output
info Copying 196 asset files
info Done copying assets
Converting JS bundle to byte code via Hermes, running command:
node_modules/hermes-engine/osx-bin/hermes -emit-binary -out CodePush/index.android.bundle.hbc CodePush/index.android.bundle -output-source-map -w
Releasing update contents to CodePush:
Successfully released an update containing the "CodePush" directory to the "Staging" deployment of the "MyApp-Android" app.
Environment
react-native-code-push version: 6.2.0
react-native version: 0.62.2
appcenter-cli: 2.6.0
The text was updated successfully, but these errors were encountered:
rcstanciu
changed the title
Hermes binary build deleted after upload
Hermes binary bundle deleted after upload
Jun 23, 2020
I've checked the source code of appcenter-cli and I found that this is the expected behavior: the HBC build overrides the JS build. Here is the actual code reference:
I will close this now as this is not an issue anymore.
Still, this build/sourcemap cannot be used with Bugsnag because, as I've been explained here bugsnag/bugsnag-react-native#463 (comment), the sourcemap is rendered in binary format when building through CodePush.
Steps to Reproduce
Expected Behavior
I specifically set
--output-dir .
as I want to upload the resulting bundle and sourcemap to Bugsnag. I expect, after runningrelease-react
command to find the binary bundle and the sourcemap in current directory.Actual Behavior
CodePush creates a
CodePush
directory in current directory, where I can find the JS bundle and sourcemap (index.android.bundle
andindex.android.bundle.map
), the binary sourcemap (index.android.bundle.hbc.map
) but no binary bundle (which I expect to beindex.android.bundle.hbc
).I watched the directory, as CodePush was creating the bundles, and I saw that the file gets created but disappears immediately (moved/deleted?), possibly when starting the upload. These are the logs:
Environment
The text was updated successfully, but these errors were encountered: