Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodePushDeploymentKey react-native link bug when using firebase #661

Closed
Yox2l opened this issue Jan 5, 2017 · 6 comments
Closed

CodePushDeploymentKey react-native link bug when using firebase #661

Yox2l opened this issue Jan 5, 2017 · 6 comments

Comments

@Yox2l
Copy link

Yox2l commented Jan 5, 2017

  • react-native-code-push version: 1.16.1-beta
  • react-native version: 0.39.2

I'm using firebase in my react-native app and therefore I have a GoogleService-Info.plist in my project now when I run the "react-native link" command the CodePushDeploymentKey added to GoogleService-Info.plist instead of the Info.plist file.
@axemclion
Copy link

Looks like it is due to this line - https://github.com/Microsoft/react-native-code-push/blob/master/scripts/postlink/ios/postlink.js#L52

We need to look for Info.plist, not *Info.plist.

cc @vladimir-kotikov

@vladimir-kotikov
Copy link

Yeah, changing the glob's pattern is the simplest approach, but we were thinking about more advanced one - reading path to/name of *.plist from xcode project rather than globbing it by pattern.

max-mironov pushed a commit to max-mironov/react-native-code-push that referenced this issue Jan 9, 2017
Improved logic for searching plist file path for iOS postlink.js
35490b2 
Added Xcode package for parsing xcodeproj file and retrieving correct plist file related to the project. This should also fix issue described here: microsoft#661
max-mironov pushed a commit to max-mironov/react-native-code-push that referenced this issue Jan 9, 2017
Improved logic for searching plist file path for iOS postlink.js
c7e23a4 
Added Xcode package for parsing xcodeproj file and retrieving correct plist file related to the project. This should also fix issue described here: microsoft#661
@max-mironov max-mironov mentioned this issue Jan 9, 2017
Merged
max-mironov pushed a commit that referenced this issue Feb 21, 2017
Improved logic for searching plist file path for iOS postlink.js (#666)
0c2aa44 
* Improved logic for searching plist file path for iOS postlink.js

Added Xcode package for parsing xcodeproj file and retrieving correct plist file related to the project. This should also fix issue described here: #661

* Improved logic for searching plist file path for iOS postlink.js

Added logic to narrow xcode 'getBuildProperty' function results to specified Product_Name property. This should help us to chsose correct project from pbxproj file when we have several projects defined.

* Added logic to try to get 'Release' build of ProductName matching the package name first and if it doesn't exist then try to get any other if existing
@max-mironov
Copy link
Contributor

Closed it for now as a pull request with fixes has been already merged.

@jordanmkoncz
Copy link

jordanmkoncz commented Apr 3, 2017 •
edited
Loading

@max-mironov Has this fix made it into a release yet? I've just followed the CodePush setup instructions from scratch, with "react-native-code-push": "^1.17.3-beta" being installed, and I had this same issue happen.

@max-mironov
Copy link
Contributor

@jordanmkoncz hello - yes, that fix should be present in recent 1.17.3 beta version.
If you still see the issue is it possible for you to open another ticket and fill as much details as possible here and we will look at?

@jordanmkoncz jordanmkoncz mentioned this issue Apr 3, 2017
Closed
@jordanmkoncz
Copy link

@max-mironov Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@axemclion @jordanmkoncz @vladimir-kotikov @Yox2l @max-mironov