Implementation first pass #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
June 24, 2015 00:15
| @@ -3,9 +3,10 @@ | |||
| "version": "0.0.1", | |||
| "private": true, | |||
| "scripts": { | |||
| "start": "node_modules/react-native/packager/packager.sh" | |||
| "start": "node_modules/react-native/packager/packager.sh --root ../../" | |||
There was a problem hiding this comment.
what script is this? why do you need it?
There was a problem hiding this comment.
The packager.sh is shipped with React Native, and is used to package all the JS files. I had to add an extra "root" to the package because it doesn't currently support symlinks, so "npm link"ing the core library into the example's node_modules wouldn't work.
|
LGTM! |
itsananderson
pushed a commit
that referenced
this pull request
Jul 24, 2015
Implementation first pass
This was referenced Feb 5, 2016
Merged
max-mironov
pushed a commit
to max-mironov/react-native-code-push
that referenced
this pull request
May 5, 2017
…d_apps Support for brownfield apps for iOS
ruslan-bikkinin
referenced
this pull request
in ruslan-bikkinin/react-native-code-push
Sep 22, 2017
DmitriyKirakosyan
pushed a commit
that referenced
this pull request
Mar 20, 2023
Bump react-native test app version to 0.71.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still pretty rough. All it does is query for updates and display if any are available. Still need to hook the example up to the "apply update" code on the native side.