Fix incorrect link behaviour introduced with promise addition in ios postlink script #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ruslan-bikkinin, |
sergey-akhalkov
approved these changes
Sep 18, 2017
scripts/postlink/run.js
Outdated
|
|
||
| //run them sequentially | ||
| var result = postlinks.reduce((p, fn) => p.then(fn), Promise.resolve()); |
There was a problem hiding this comment.
Do we really need result variable here?
Would it probably better to do the following:
postlinks.reduce((p, fn) => p.then(fn), Promise.resolve())
.catch((err) => {
console.error(err.message);
});There was a problem hiding this comment.
Not at all, I'll simplify it as you suggested, @sergey-akhalkov, thx!
ruslan-bikkinin
force-pushed
the
fix-postlink
branch
from
9f04010
to
8a063af
Compare
|
Confirmed fix: #999 (comment) |
ruslan-bikkinin
added a commit
to ruslan-bikkinin/react-native-code-push
that referenced
this pull request
Sep 21, 2017
postlink script (microsoft#1003)` transfer from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to promise usage in ios postlink script all postlink scripts should be promisified. This PR provide fix for this.
Also its related to #999