Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double hash checking support for code signing #1005

Merged

Conversation

ruslan-bikkinin
Copy link
Contributor

This PR improves code signing verification providing transitive verification between package hash, computed update folder hash and content hash from jwt payload on SDK side.

@msftclas
Copy link

@ruslan-bikkinin,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Copy link
Contributor

@max-mironov max-mironov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruslan-bikkinin ruslan-bikkinin merged commit e1cdd90 into microsoft:master Sep 18, 2017
@ruslan-bikkinin ruslan-bikkinin deleted the add-double-check-support branch September 19, 2017 14:07
@max-mironov max-mironov removed their assignment Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants