Fix dex index overflow exception #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-mironov
reviewed
Sep 18, 2017
| SignedJWT signedJWT = SignedJWT.parse(jwt); | ||
| JWSVerifier verifier = new RSASSAVerifier((RSAPublicKey)publicKey); | ||
| if (signedJWT.verify(verifier)) { | ||
| return signedJWT.getJWTClaimsSet().getClaims(); |
There was a problem hiding this comment.
Does it make sense to keep logging here to help devs to debug going further?
There was a problem hiding this comment.
fixed, thanks!
ruslan-bikkinin
suggested changes
Sep 18, 2017
| return signedJWT.getJWTClaimsSet().getClaims(); | ||
| } | ||
| return null; | ||
| } catch (Exception ex) { | ||
| return null; |
There was a problem hiding this comment.
I think we need to add exception logging here to be able determine cause of problem in future:
CodePushUtils.log(ex.getMessage());
CodePushUtils.log(ex.getStackTrace().toString());…jwt #1002 use another lib - nimbus-jose-jwt
ruslan-bikkinin
approved these changes
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1002