Refactor plugin config, and change example so it can download updates #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| jsCodeLocation = [HybridMobileDeploy appBundleUrl]; | ||
|
|
||
| //jsCodeLocation = [HybridMobileDeploy getBundleUrl]; |
There was a problem hiding this comment.
Why not delete the commented code?
There was a problem hiding this comment.
Both of these configurations are convenient for testing different scenarios, so it's nice to be able to switch back and forth by commenting them out. However, there's no need to change the checked-in state from what it was before, so I'll revert this.
|
LGTM |
added 8 commits
July 24, 2015 12:48
itsananderson
pushed a commit
that referenced
this pull request
Aug 21, 2015
Refactor plugin config, and change example so it can download updates
This was referenced Feb 4, 2016
Merged
sergey-akhalkov
pushed a commit
that referenced
this pull request
Jul 17, 2017
raedur
pushed a commit
to happy-co/react-native-code-push
that referenced
this pull request
Jul 31, 2017
Android implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple big changes here:
Still todo: finish refactoring the code to better reflect Richard's native plugin interface.