Update api to match Cordova implementation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
August 28, 2015 12:20
| return NativeCodePush.downloadUpdate(this) | ||
| .then((downloadedPackage) => { | ||
| return extend({}, downloadedPackage, local); | ||
| }); |
There was a problem hiding this comment.
what happens if the download fails? cordova side has an error handller for this
There was a problem hiding this comment.
Since we return a promise, any errors thrown by downloadUpdate() will be bubbled up to the calling code.
|
LGTM |
|
|
||
| [CodePush loadBundle]; | ||
|
|
||
| //resolve([NSNull null]); |
| @@ -1,4 +1,4 @@ | |||
| /** | |||
| /*y | |||
There was a problem hiding this comment.
Accidental change. I'll revert.
|
minor comments, LGTM otherwise!! 👍 |
itsananderson
pushed a commit
that referenced
this pull request
Sep 29, 2015
Update api to match Cordova implementation
max-mironov
pushed a commit
to max-mironov/react-native-code-push
that referenced
this pull request
Jul 6, 2017
…d_apps_v2 Support for brownfield apps v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty big refactor. Pulled out most of the package handling code to a distinct
CodePushPackage.mfile. Still a few pieces of polish I need to do on the Obj-C code, but I wanted to get this out for review since I've been working on it in private for so long.