CodePush.js: fix syncStatus value mismatch #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After `SyncStatus` correctly goes to `UPDATE_INSTALLED`, on the next resume it transitions to `CHECKING_FOR_UPDATE` and then `UP_TO_DATE`, even though the update has not yet been installed. It should be equals to `UPDATE_INSTALLED` value again until next app restart.
|
@sergey-akhalkov, |
richardhuaaa
approved these changes
Mar 30, 2017
peacechen
pushed a commit
to peacechen/react-native-code-push
that referenced
this pull request
May 3, 2017
After `SyncStatus` correctly goes to `UPDATE_INSTALLED`, on the next resume it transitions to `CHECKING_FOR_UPDATE` and then `UP_TO_DATE`, even though the update has not yet been installed. It should be equals to `UPDATE_INSTALLED` value again until next app restart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
SyncStatuscorrectly goes toUPDATE_INSTALLED, on the next app resume it transitions toCHECKING_FOR_UPDATEand thenUP_TO_DATE, even though the update has not yet been installed. It should be equals toUPDATE_INSTALLEDvalue again until next app restart.Relates to #760